Add binary source and destination settings #122
Merged
+65
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to use axios.getUri() but it does not take into account the base URL in older versions.
code-asher
force-pushed
the
asher/bin-source-dest
branch
from
c6f5855
to
78c4763
Compare
kylecarbs
approved these changes
Aug 11, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103.
This provides two ways for folks to work around security restrictions where the binary can only be ran from specific directories or has to be signed.
The former can be worked around by setting the destination, and the latter can be worked around by setting the source and providing signed binaries.
Eventually we should look into providing signed binaries straight from Coder.
I started writing tests, however there are so many VS Code APIs to mock I abandoned the idea. We should revisit once we switch back to the standard testing framework.